nahsra / WebGoat_12_23

Other
0 stars 2 forks source link

Implemented parsing usage when converting Strings to primitives (Sonar) #9

Closed pixeebot[bot] closed 5 months ago

pixeebot[bot] commented 6 months ago

This change updates String-to-number conversions by leveraging the intended parse methods.

This change makes developer intent clearer, and sometimes with a more concise expression.

Our changes look like this:

    String number = "7.1";

-   int integerNum = Integer.valueOf(number);
+   int integerNum = Integer.parseInt(number);

-   float floatNumVal = Float.valueOf(number).floatValue();
+   float floatNumVal = Float.parseFloat(number);

-   int integerNumber = new Integer(number);
+   int integerNumber = Integer.parseInt(number);
More reading * [https://rules.sonarsource.com/java/RSPEC-2130/](https://rules.sonarsource.com/java/RSPEC-2130/)

I have additional improvements ready for this repo! If you want to see them, leave the comment:

@pixeebot next

... and I will open a new PR right away!

Powered by: pixeebot (codemod ID: sonar:java/harden-string-parse-to-primitives-s2130)

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

pixeebot[bot] commented 5 months ago

I'm confident in this change, and the CI checks pass, too!

If you see any reason not to merge this, or you have suggestions for improvements, please let me know!

pixeebot[bot] commented 5 months ago

Just a friendly ping to remind you about this change. If there are concerns about it, we'd love to hear about them!

pixeebot[bot] commented 5 months ago

This change may not be a priority right now, so I'll close it. If there was something I could have done better, please let me know!

You can also customize me to make sure I'm working with you in the way you want.