Open jlag34 opened 5 years ago
Thanks for your review. Here are some of my considerations:
For criteria 3: I feel I could be more efficient in the code, like if I'd used too many selectors. The same feeling in the css code.
For criteria 4: I just didn't realise I had to make it fancy, neither had the time xD.
So do you have any particular tip for these issues or I should just don't worry about it?
Criteria 1: HTML Structure
Criteria 2: Visual Layout for Both Desktop and Mobile Sizes
Criteria 3: Responsive Design (Media Queries, Responsive Units, etc.)
Criteria 4: Visual Design and Accessibility (Color Palette, Typography, Transitions, etc.)
Overall Score: 12/16
Overall, you did a good job. The focus of this project was on media queries and you handled them nicely. Your layout for both views was very good and just needed a little extra polish on how they collapsed. Good job on your HTML, everything was really nice. The only thing your project lacked was a bit of styling to bring it to life. Adding a nice color scheme and a few hover effects would really make it pop. Other than that, great job.