Redmine 1.4 compatibility

[GoogleCodeExporter]

The plugin don't work with Redmine 1.4

Original issue reported on code.google.com by luisete....@gmail.com on 18 Apr 2012 at 7:10

[GoogleCodeExporter]

http://www.redmine.org/boards/3/topics/30085?r=30099

Original comment by luisete....@gmail.com on 18 Apr 2012 at 2:05

[GoogleCodeExporter]

With DMSF Stable and the attached patch, everything is working fine with 
Redmine 1.4.

But if you are on DMSF SVN Trunk. These Error according to custom fields arise:

ActionView::TemplateError (undefined local variable or method 
`dmsf_file_revision_custom_fields' for #<Project:0x7f12e94ec9f8>) on line #3 of 
vendor/plugins/redmine_dmsf/app/views/dmsf/_custom_fields.html.erb:
1: <% unless object.nil? %>
2: <div class="dmsf-customfields">
3:  <% object.show_custom_field_values.each do |custom_value| %>
4:      <div class="dmsf-customfield-<%= custom_value.custom_field.id %> 
dmsf-customfield customfield">
5:          <%= label_tag("", h(custom_value.custom_field.name) + ":") %> <%= 
show_value(custom_value) %>
6:      </div>

ActionView::TemplateError (undefined local variable or method 
`dmsf_file_revision_custom_fields' for #<Project:0x7f9f6908d710>) on line #39 
of vendor/plugins/redmine_dmsf/app/views/dmsf/edit.html.erb:
41:             <p><%= custom_field_tag_with_label(:dmsf_folder, value) %></p>
    vendor/plugins/redmine_dmsf/app/models/dmsf_folder.rb:193:in `available_custom_fields'
    vendor/plugins/redmine_dmsf/app/views/dmsf/edit.html.erb:39
    vendor/plugins/redmine_dmsf/app/views/dmsf/edit.html.erb:13
    vendor/plugins/redmine_dmsf/app/controllers/dmsf_controller.rb:148:in `new'
  Parameters: {"action"=>"new", "id"=>"tma", "controller"=>"dmsf"}

<pre>
ActionView::TemplateError (undefined local variable or method 
`dmsf_file_revision_custom_fields' for #<Project:0x7fe7ea95adb0>) on line #70 
of vendor/plugins/redmine_dmsf/app/views/dmsf_upload/_upload_file.html.erb:
72:         <p><%= 
custom_field_tag_with_label("commited_files[#{i}][dmsf_file_revision]", value) 
%></p>
    vendor/plugins/redmine_dmsf/app/models/dmsf_folder.rb:193:in `available_custom_fields'
    vendor/plugins/redmine_dmsf/app/views/dmsf_upload/_upload_file.html.erb:70
    vendor/plugins/redmine_dmsf/app/views/dmsf_upload/upload_files.html.erb:25
    vendor/plugins/redmine_dmsf/app/views/dmsf_upload/upload_files.html.erb:21:in `each'
    vendor/plugins/redmine_dmsf/app/views/dmsf_upload/upload_files.html.erb:21
    vendor/plugins/redmine_dmsf/app/views/dmsf_upload/upload_files.html.erb:18
</pre>

I'm not familiar with Ruby and Redmine Plugins, perhaps someone can provide a 
solution!

Original comment by simon.sw...@gmail.com on 14 May 2012 at 12:17

Attachments:

• redmine_1.4_dmsf.patch

[GoogleCodeExporter]

Works in Redmine 2.0 ?

I try in my updated REdmine 2.0 and not migrate correctly

Original comment by luisete....@gmail.com on 15 May 2012 at 6:22

[GoogleCodeExporter]

I need help porting this to Redmine 2.0 as well.
Thanks

Original comment by RafiGree...@gmail.com on 17 May 2012 at 9:05

[GoogleCodeExporter]

This routes.rb restored full Redmine 1.4.2 for DMSF 1.2.2 for mee:

ActionController::Routing::Routes.draw do |map|
  map.resources :dmsf, :only => [:new, :create, :show, :edit], :member => {
    'edit_root' => :get,
    'entries_operation' => :post,
    'notify_activate' => :post,
    'notify_deactivate' => :post,
    'save_root' => :post,
    'delete_entries' => :post,
    'delete' => :post,
    'save' => :post
  }
  map.resources :dmsf_files
  map.connect 'dmsf/:id/dmsf_files/:action', :controller => 'dmsf_files'
  map.connect 'dmsf/:id/dmsf_state/:action', :controller => 'dmsf_state'
  map.connect 'dmsf/:id/dmsf_detail/:action', :controller => 'dmsf_detail'
  map.connect 'dmsf/:id/dmsf_upload/:action', :controller => 'dmsf_upload'
  map.connect 'dmsf/:id/dmsf_files_copy/:action', :controller => 'dmsf_files_copy'
  map.connect 'dmsf/dmsf_folders_copy/:action', :controller => 'dmsf_folders_copy'
end

Original comment by mjn.cor...@gmail.com on 25 May 2012 at 1:03

[GoogleCodeExporter]

One addition to solve remaining issues with folder copying.
Change the route for dmsf_folders_copy (last line) to:

map.connect 'dmsf/:id/dmsf_folders_copy/:action', :controller => 
'dmsf_folders_copy'

Original comment by mjn.cor...@gmail.com on 29 May 2012 at 12:18

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I also added:
map.connect 'dmsf/:id/user_pref_save/:action', :controller => 'user_pref_save'
because configureing DMSF didn't work

Original comment by beurtvaa...@gmail.com on 31 May 2012 at 1:19

[GoogleCodeExporter]

Who can help to get this plugin working for Redmine 2.0.x?
Thanks!

Original comment by RafiGree...@gmail.com on 31 May 2012 at 5:39

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

As I've informed repo owner, I've forked their distribution at 
https://github.com/danmunn/redmine_dmsf - this distribution although devel is 
Redmine 2.0 functional, also addresses some of the issues reported.

Original comment by dan.m...@munnster.co.uk on 8 Jun 2012 at 7:36

[GoogleCodeExporter]

@danmunn

Many thanks for the great job

Original comment by tuxin...@googlemail.com on 8 Jun 2012 at 8:20

[GoogleCodeExporter]

Please can you test trunk version using *project_patch.rb* in 

  ~redmine_dmsf/lib/redmine_dmsf/patches/project_patch.rb

attached to this issue?

Thanks.

Original comment by mav...@gmail.com on 21 Jun 2012 at 2:18

Attachments:

• project_patch.rb