Open rtrudel opened 4 years ago
Very nice tool!
If I may suggest something, why not having ability to add default parameters (globally)? Those can easily merged to $data
$data
Ex:
<?php return [ 'app_id' => env('PUSH_APP_ID'), 'api_key' => env('PUSH_API_KEY'), 'params' => [ 'priority' => 10, 'android_accent_color' => 'FF3578bc', 'android_led_color' => 'FF3578bc', ] ];
In PushNotificationController.php:
... if ( ! empty($request->url)) { $data['url'] = $request->url; } // Maybe something like this? $data = array_merge($data, config('push_notifications.params')); $response = $oneSignalApi->notifications->add($data);
(I know I can also fork and add it myself...)
Very nice tool!
If I may suggest something, why not having ability to add default parameters (globally)? Those can easily merged to
$data
Ex:
In PushNotificationController.php:
(I know I can also fork and add it myself...)