search

naikus / svg-gauge

Minimalistic, animated SVG gauge. Zero dependencies
MIT License
319 stars 74 forks source link

Be able to set class names for gauge. #4

Closed HejdesGit closed 8 years ago

HejdesGit commented 8 years ago

I have added the ability to set the gauge class names.

We are using BEM and our css-lint is giving us warnings for the class names.

I also added some git ignores.

naikus commented 8 years ago

Hi, I'm travelling and will be able to review this the day after.

On Oct 31, 2016 5:35 PM, "Johan" notifications@github.com wrote:

I have added the ability to set the gauge class names.

We are using BEM http://getbem.com/introduction/ and our css-lint is giving us warnings for the class names.

I also added some git ignores.

You can view, comment on, or merge this pull request online at:

https://github.com/naikus/svg-gauge/pull/4 Commit Summary

  • Be able to set class names for gauge.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/naikus/svg-gauge/pull/4, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZxDvJV_dTKWDd1DaMZOfWKGnWF8rz-ks5q5dmNgaJpZM4Kk8Xr .

HejdesGit commented 8 years ago

Sounds good. Let me know if I should change something.