search

naipotato / Replay

[DEVELOPMENT MIGRATED] Explore and watch your favorite videos
https://code.potato.zone/replay-app/replay
GNU General Public License v3.0
156 stars 8 forks source link

views: Fix unowned fields #52

Closed lifeiscontent closed 3 years ago

lifeiscontent commented 3 years ago

Saw a couple of warnings in your basic-layout branch, so I fixed them for ya.

naipotato commented 3 years ago

Saw a couple of warnings in your basic-layout branch, so I fixed them for ya.

Oh, it seems that https://gitlab.gnome.org/GNOME/vala/-/issues/1121 got fixed already. I would have preferred fields marked with [GtkChild] to be trated as implicitly unowned, but hey, is something.

naipotato commented 3 years ago

Since this branch belongs to a PR that is still work in progress, I would suggest you comment the changes there instead of opening another PR

(The PR is #47)