naipotato / Replay

[DEVELOPMENT MIGRATED] Explore and watch your favorite videos
https://code.potato.zone/replay-app/replay
GNU General Public License v3.0
156 stars 8 forks source link

Should we move Replay-Design here? #57

Closed naipotato closed 3 years ago

naipotato commented 3 years ago

Currently the repo where the designs live is somewhat separate from the app's repo. Should we consider moving it here and keeping it as an extra branch? Or maybe in a special folder within the project tree?

naipotato commented 3 years ago

I'll move the designs here, but in a design branch

lifeiscontent commented 3 years ago

@nahuelwexd Why not in the main branch in a design folder?

naipotato commented 3 years ago

@lifeiscontent I prefer to have both separately. Also, that way I can make use of git worktree to have main and design in two separate folders

lifeiscontent commented 3 years ago

@nahuelwexd I’m curious why though, for me personally if I want to look at designs I then have to stash my changes, check out a branch, store the designs locally, go back to my branch, unstash my changes and continue my work

naipotato commented 3 years ago

git worktree add ../Replay-Design design

That way I would end having:

And both strictly related, so a commit in one would appear in the other

lifeiscontent commented 3 years ago

@nahuelwexd Oh, I’m not familiar with worktree in git, I’ll need to read up on it

naipotato commented 3 years ago

@lifeiscontent I found out about worktree with a blog post by jimmac: https://blog.jimmac.eu/2021/git-worktree

Here is the documentation anyway: https://git-scm.com/docs/git-worktree

naipotato commented 3 years ago

Well, it's done

https://github.com/nahuelwexd/Replay/tree/design