search

nairobilug / pelican-alchemy

A ✨ functional, clean, responsive Pelican theme
https://nairobilug.github.io/pelican-alchemy/
MIT License
139 stars 79 forks source link

Take ✨ Alchemy to the next level #47

Closed rwanyoike closed 7 years ago

rwanyoike commented 7 years ago

Updating our chemistry. Version 2.0:

alanorth commented 7 years ago

Try using the new GitHub Projects workflow to track issues and pull requests for this milestone. 👍

rwanyoike commented 7 years ago

It's taken shape https://rwanyoike.github.io/pelican-alchemy/

alanorth commented 7 years ago

Page no function!

rwanyoike commented 7 years ago

gh-pages must be acting up, if you attach any query, ?pickles3243, it works?

alanorth commented 7 years ago

Ah, it's working now. Looks great, but so does the original pelican-alchemy. It would be good to see them side by side with the same content.

rwanyoike commented 7 years ago

you're right! I got gh-pages to work on my fork, https://rwanyoike.github.io/nairobilug.or.ke/ <-> https://nairobilug.or.ke/.

alanorth commented 7 years ago

Mash'allah. ﷲ. It looks fantastic, dude. I'll do a closer look tomorrow to try and quantify how zesty the improvement is.

One improvement could be to just bite the bullet and switch to Bootstrap v4 though, or at least to steal its native font CSS stuff. I am using it on my Hugo blog theme and it looks great on all modern platforms and is quick to load.

alanorth commented 7 years ago

Feedback:

Really awesome work, @rwanyoike. I think this can absolutely replace the current theme immediately as is. It already has feature/functional parity with the old theme, provides extra value, and is more standards compliant—we can fix the rest after the switch.

rwanyoike commented 7 years ago

Just for the rem's 🤘

Here's the same with bootstrap v4, ported, with a bunch of 'fixes'. How does it compare: https://rwanyoike.github.io/nairobilug.or.ke2

https://rwanyoike.github.io/nairobilug.or.ke - bootstrap v3 https://nairobilug.or.ke/

alanorth commented 7 years ago

Heh, the Typography on the Bootstrap v4 one looks like crap actually. WTF? The typography on my blog looks much better and it's just plain Bootstrap v4—what's up with the fonts on your new version?

A bonus is that this new version is 30KiB smaller though, and Bootstrap v4 will be more future proof anyways.

rwanyoike commented 7 years ago

Old cache must be acting up in your region, the fonts look like your blog's in chrome. 🤔

On Dec 1, 2016 00:53, "Alan Orth" notifications@github.com wrote:

Heh, the Typography on the Bootstrap v4 one looks like crap actually. WTF? The typography on my blog looks much better https://picturingjordan.com/ and it's just plain Bootstrap v4—what's up with the fonts on your new version?

A bonus is that this new version is 30KiB smaller though, and Bootstrap v4 will be more future proof anyways.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nairobilug/pelican-alchemy/issues/47#issuecomment-264007443, or mute the thread https://github.com/notifications/unsubscribe-auth/ADgdOX1vGwWuggte4hgNa_ZjLKcmEwTLks5rDfBAgaJpZM4KqgmW .

alanorth commented 7 years ago

Great success, I shift-refreshed and now I see it. Looks great. Ship it!

By the way, for my blog I shaved off 50+ KiB by using a custom Bootstrap that only includes the typography and grid stuff, as well as only including CSS for Font Awesome icons I was using.

I know one of the goals was to keep the dependencies low, but you could pre-generate these in the theme and then only people who know how or need to change them would need npm.

rwanyoike commented 7 years ago

We can definitely can work on theme size and performance using these tips! Ref. #54