Closed sio closed 5 years ago
LTGM; we can merge this and close #63
It looks like the oldstyle.css does not actually restore the prior css for some aspects. The background colors are not correct, for example.
Here is the screenshot of the default them prior to @sio's work:
And here is the new one:
https://github.com/nairobilug/pelican-alchemy/blob/master/screenshots/oldstyle.png
Note that the header has a grey background and the rest of the page is white prior to this change.
I have fixed the background issue for oldstyle.css and have updated screenshots and demo website.
@moorepants, thank you for reporting!
@sio, thank you :)
Alchemy is a great theme, but it was not using the full potential of underlying technology. Bootstrap provides an easy way to customize look and feel of rendered pages, and a lot of themes for Bootstrap are freely available, e.g. at https://boostwatch.com
This commit introduces a new configuration variable BOOTSTRAP_CSS to make use of any existing Bootstrap skins. All incompatibilities in
theme.css
were fixed:--alchemy-border
for easier overriding if needed. I have tested current value against both dark and light Boostwatch themes, it works ok.I understand that you're using this theme on several web sites including https://nairobilug.or.ke/. After applying these changes resulting web sites will look slightly different - not all hardcoded colors could be replaced with variables in such a way that produced consistently good results across different Bootstrap skins.
There are several options:
I've noticed a similar pull request (#63) only when I went to submit this one. Apart from mine being newer (hence guaranteed to merge cleanly) I consider my approach slightly more generic and therefore favorable :)
Thank you for creating this beautiful theme! :+1: There are very few good themes for Pelican!
PS: your website is so much cooler than that of my local LUG :tada: