search

nais / naisd

nais deployment daemon
https://nais.io
MIT License
27 stars 10 forks source link

Delete replicaSet for app #107

Closed linemos closed 6 years ago

gtcno commented 6 years ago

Why is this necessary? Does a delete of a deployment not trigger a cascading delete of rs?

linemos commented 6 years ago

@gtcno It should, but it does not. I have not found out why.

linemos commented 6 years ago

Cannot reproduce the problem right now. Perhaps the bug was somewhere else... 🤔

gtcno commented 6 years ago

This is a wormhole. But i thought this was fixed here https://github.com/kubernetes/kubernetes/pull/44058.

I do think we should be careful with deleting resources that we dont explicitly create. Are we sure the deployment controller doesnt recreate a replicaset if you delete one that is created by a deployment? And yeah we do delete the deployment. But kubernetes controllers are asyn so race conditions might occur.