nais / naisd

nais deployment daemon
https://nais.io
MIT License
27 stars 10 forks source link

Inject webproxy variables only when requested #123

Closed kimtore closed 6 years ago

kimtore commented 6 years ago

This fixes a service discovery regression introduced in 4d7a9f68c7313e1c28d188b8d63d62f3501f71ad, where unconditional web proxy settings injection caused trouble for applications doing service discovery.

Apparently, the NO_PROXY variable applies to hosts before the DNS lookup is returned. Thus, filtering on cluster level (e.g., .local, .adeo.no, etc.) will not work if applications only specify the host name component.

This commit reintroduces the webproxy manifest property so that application maintainers can decide for themselves whether or not they want the variables injected.