Wait for deployment - Githubissues

nais / naisd

nais deployment daemon

https://nais.io

MIT License

27 stars 10 forks source link

Wait for deployment #50

Closed davidsteinsland closed 7 years ago

davidsteinsland commented 7 years ago

Adds --wait flag to nais deploy to hang until the deployment has completed (or failed)
Adds a nais wait command to wait for a deployment for a given app
Makes the cluster URL editable by setting NAIS_CLUSTER_URL env var. The URL is resolved using the following priority:
- Command line, via --cluster or -c argument
- Environment, NAIS_CLUSTER_URL,
- Default value, preprod-fss

davidsteinsland commented 7 years ago

any thoughts on this?

androa commented 7 years ago

What is the use case? For deployment purposes we had the same issue, and went for a pulling approach with kubectl. That sucked. --wait in that sense seems better.

Ideally I would have solved this by having a callback URL in the deploy command and have naisd call that when the deployment is successfull. Most CIs has steps for waiting for HTTP callbacks.