search

nais / naisd

nais deployment daemon
https://nais.io
MIT License
27 stars 10 forks source link

write ingress for public address in sbs #74

Closed jan-berge-ommedal closed 6 years ago

jan-berge-ommedal commented 6 years ago

make an additional ingress entry for every app deployed to sbs that exposes the application on tjenester.nav.no/

gtcno commented 6 years ago

Hmm. I thought this was allready implementere through loadbalancer config in FASIT

gtcno commented 6 years ago

See #46

audunstrand commented 6 years ago

Also tjenester.nav.no should be a parameter or configurable, not hard coded

jan-berge-ommedal commented 6 years ago

@gtcno correct, it is possible to achieve the same ingress through lbConfig in fasit. However, as far as I can see (which might not be far enough) every application in sbs should have this exact lbConfig, so why require manual configuration in fasit? Also, it is not possible to provision the correct lbConfig for sbs-apps using basta, which may lead to confusion among developers since this is their familiar tool for setting this up. Lastly, isn't the long term strategy for naisd to be less dependent on fasit?

@audunstrand agreed, but where do you want this to be defined? Keep in mind that tjenester.nav.no is the only valid value atm.

@Kyrremann @davidsteinsland did some refactoring https://github.com/nais/naisd/pull/74/commits/e958d6d25247c56d0787f379d510729344f2f12f thanks!

gtcno commented 6 years ago

I agree with less Fasit. An alternative approach is perhaps to extend clusterSubdomain (give better name!) to handle a list of host strings for which to make ingresses.

gtcno commented 6 years ago

After a discussion we will pick this up when we hit a similar "problem" in FSS. So allow for now.