search

nais / naisd

nais deployment daemon
https://nais.io
MIT License
27 stars 10 forks source link

Renamed appconfig to manifest #76

Closed Kyrremann closed 6 years ago

Kyrremann commented 6 years ago

Got a little bit irritated that we used both the name appconfig and manifest. manifest is the new and correct way.

davidsteinsland commented 6 years ago

Will there be a grace period here, where this will be rolled out to preprod clusters first? I am assuming everyone using the nais deploy cmd / curl or JIRA Auto Deploy will have to update their code

Kyrremann commented 6 years ago

If they are sending in a different yaml then what's in Nexus, they need to update. The only external thing that is changing is the REST-endpoint /deploy and the argument appconfigurl=, which will be manifesturl= from now. Grace periode is possible.

The normal flow of a cURL call is to use the default, which retrieves from Nexus.

audunstrand commented 6 years ago

I agree with david.need to use expand contract here to maintain backwards compabilty.

Also I feel that that word app adds meaning. appManifest

audunstrand commented 6 years ago

I also agree on changing function names as well as variables

Kyrremann commented 6 years ago

We can implement a deprecation periode, where we can have both fields, and use the one that is not empty?

@audunstrand can change to appManifest, but I'm hoping we don't need more manifests, so that having just one is self explanatory.

Kyrremann commented 6 years ago

@davidsteinsland thoughts on deprecation period? Use both for the next week? So removed it the 1th of February.

davidsteinsland commented 6 years ago

@Kyrremann sounds good 👍🏻