search

nais / teams-backend

NAIS teams is a API server for team creation and propagation to external systems.
MIT License
3 stars 0 forks source link

GitHub reconciler fails when trying to remove IDP sync on a local team #77

Closed christeredvartsen closed 1 year ago

christeredvartsen commented 1 year ago

If the GitHub reconciler creates a team, the team is considered a local team. The reconciler will then fail when it tries to remove the potential IDP connection. We will need to check if the team is remotely controlled before trying to remove the connection.

christeredvartsen commented 1 year ago

After some digging the issue occurs when the organization itself is not configured for Team IDP Sync. There does not seem to be any way to programatically detect this yet, so we will probably need to check the returned error to get around this.

christeredvartsen commented 1 year ago

An issue / feature request has been sent to GitHub regarding this.