Elora's player attack bonus not picked up in regex

[GoogleCodeExporter]

As far as I can tell, Elora's skill

"While equipped, increases Player Attack by 15 and decreases Max Energy by 15"

should be recognized by this regex in worker_ca_generals.js 
(http://code.google.com/p/game-golem/source/browse/trunk/worker_ca_generals.js#4
12):

j = Math.floor(sum(skillcombo.regex(/([-+]?\d*\.?\d+) Player Attack\b|\bPlayer 
Attack by ([-+]\d+)\b|\bConvert ([-+]?\d*\.?\d+) Attack\b/gi))

However, there's no "patt" adjustment showing up in Elora's skills in 
Generals.runtime, so she doesn't get rated as the PVP stud she is.  I'm 
stumped.  Maybe someone better at regular expressions can see what I'm missing.

Original issue reported on code.google.com by masonv...@gmail.com on 27 May 2011 at 11:45

[GoogleCodeExporter]

There were some errors elsewhere in that entire parsing block, is it fixed in 
1136+ ?

Original comment by RycochetTM on 1 Jun 2011 at 3:59

• Changed state: Started
• Added labels: Worker-CA-Generals

[GoogleCodeExporter]

As of 1137, it doesn't seem to be fixed, but I'm not sure I'm being successful 
in forcing the generals data to be reparsed.  Is there any trick for forcing 
the generals to be reevaluated without a global reset?

Original comment by masonv...@gmail.com on 1 Jun 2011 at 7:26

[GoogleCodeExporter]

Set "rev" to true in Generals.runtime and restarted and it looks like it went 
through and reviewed all the generals.  Elora still didn't get her player 
attack bonus picked up.

Original comment by masonv...@gmail.com on 1 Jun 2011 at 7:39

[GoogleCodeExporter]

Does r1161 properly parse Elora? I think the "patt" part had been parsing 
correctly for some time, but it looked to me like the max energy deduction 
would have been turning into a bonus instead. The skill stats for her should 
look like "patt" = 15 and "maxenergy" = -15 if it is now parsing correctly.

Original comment by lur...@hotmail.com on 25 Sep 2011 at 7:32

• Changed state: Verify