naja-js / naja

Modern AJAX library for Nette Framework

https://naja.js.org

MIT License

109 stars 16 forks source link

fixed sending array in AJAX request #207

Closed petrparolek closed 3 years ago

petrparolek commented 3 years ago

closes #202

codecov[bot] commented 3 years ago

Codecov Report

Merging #207 (3a9a8de) into master (35f2a20) will decrease coverage by 0.96%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   84.34%   83.38%   -0.97%     
==========================================
  Files          11       11              
  Lines         345      349       +4     
  Branches       99      100       +1     
==========================================
  Hits          291      291              
- Misses         21       24       +3     
- Partials       33       34       +1

Impacted Files	Coverage Δ
src/Naja.ts	`89.85% <0.00%> (-5.53%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35f2a20...3a9a8de. Read the comment docs.

petrparolek commented 3 years ago

thanks @DzeryCZ very much for providing a lot of helps with fixing.

jiripudil commented 3 years ago

Hello, first of all, thanks for the contribution, every helping hand counts!

This definitely goes in the right direction, but since this issue is already on the table, I'd like to have it fixed properly, i.e.

Naja should transform everything that PHP and/or Nette can correctly parse, including arrays (key[]=value), objects (key[subkey]=value), and any arbitrarily nested structures (key[subkey][0][subkey]=value).
In addition to GET and HEAD requests where data need to be serialized into the query string, the same transformation also needs to be done to application/x-www-form-urlencoded request body – currently it suffers from pretty much the same bug on this line.
Needless to say, this kind of change needs a decent test coverage.

Let me know if you're willing to put more effort into this, I might have some thoughts on how this could be implemented. Otherwise I might be able to find some time for this during this or the following week. I believe this is not a blocker, as you can always build the URL in your code until this is fixed.

petrparolek commented 3 years ago

I am not good at Javascript. It's up to you. Could you fix it in your way?

jiripudil commented 3 years ago

I am not good at Javascript. It's up to you. Could you fix it in your way?

Sure, no worries :) by the way your code is really not bad, it's just that the scope of the problem is larger than you expected.

petrparolek commented 3 years ago

code is from my friend @DzeryCZ .

jiripudil commented 3 years ago

Well then, thanks to both of you for putting your time and effort into this!