search

najamelan / ws_stream_tungstenite

Provide AsyncRead/AsyncWrite over tungstenite websockets
31 stars 16 forks source link

Pulls in native-tls, even if used with rustls #5

Closed MathiasKoch closed 4 years ago

MathiasKoch commented 4 years ago

Because this crate enables default features for tungstenite, it effectively pulls in native-tls, even if the intention is to use it with rustls as evidenced by https://github.com/bytebeamio/rumqtt/pull/193

najamelan commented 4 years ago

Ah, good catch. I will disable default features. Do you need a 0.3 version with this fixed or is it ok if I put it in the 0.4.0-beta? The 0.4 line uses tokio 0.3.

MathiasKoch commented 4 years ago

The 0.4 line is fine for me 👍 thank you!

najamelan commented 4 years ago

Nice, because it's a breaking change, so I would have had to move the beta versions to 0.5 and release a 0.4 in between. I'll try to fix this today and I will go over all deps to make sure they are minimal. Sorry for the inconvenience.

MathiasKoch commented 4 years ago

Thank you very much! 😀

najamelan commented 4 years ago

Ok, version 0.4.0-beta.2 has been released. It strips thiserror and sets default-features: false on everything else. Thanks for the bug report.