search

naji-97 / space-travelers-hub

MIT License
2 stars 0 forks source link

space-travelers-hub #25

Open naji-97 opened 1 year ago

naji-97 commented 1 year ago

GitHub project: https://github.com/naji-97/space-travelers-hub.git

we are 2 partners working on this project

TayyabKM commented 1 year ago

I am in the meeting my brother.

franclobo commented 1 year ago

Hi @naji-97 and @TayyabKM,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted an issue with the wrong link to the project you have submitted the link to your repo and didn't specify the number of members in the group. Unless student success authorizes to continue this block alone all the PR will be invalidated due to all the activities being pair programming.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

arslanbisharat commented 1 year ago

Hi @franclobo, Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.