Issue #2 Fail when copy data exceeds defined max-size

nakabonne / pbgopy

Copy and paste between devices

MIT License

807 stars 30 forks source link

Issue #2 Fail when copy data exceeds defined max-size #10

Closed faithfulnessalamu closed 3 years ago

faithfulnessalamu commented 3 years ago

Register a max-buffer-size flag in copy command which defaults to 500MB
Fail with an error when data to be copied exceeds the maximum buffer size set using the maxSize flag

faithfulnessalamu commented 3 years ago

@nakabonne Still a WIP, please take a look and comment. What do you think about allowing users specify the data unit. For example "4kb", "5GB" and so on.

nakabonne commented 3 years ago

@thealamu Thanks for your contribution!

allowing users specify the data unit

Totally agree with you. It would be nice to be able to specify in lower case as; 1kb, 1mb, 1gb.

nakabonne commented 3 years ago

Thank you! I'm in the middle of something, so I'll take a look later!

faithfulnessalamu commented 3 years ago

Okay, I'm also currently working on not allocating memory ahead of time

faithfulnessalamu commented 3 years ago

Ready for review @nakabonne

nakabonne commented 3 years ago

And I'm sorry but could you resolve the conflicts?

faithfulnessalamu commented 3 years ago

Thank you :rocket: