search

nakabonne / pbgopy

Copy and paste between devices
MIT License
807 stars 30 forks source link

Issue #4 - Stop using an empty nonce for GCM #11

Closed keyslapperdev closed 3 years ago

keyslapperdev commented 3 years ago

In crypto/crypto.go Used crypto/rand to supply secure random data to fill the nonce Created func GetNonce to contain logic for generating the nonce given the nonce size Removed unused function RandomBytes. The functionality provided is simple to replicate if needed in the future. So for now, I'd just rather remove the cognative load of just having that there.

In crypto/crypto_test.go Removed tests for RandomBytes

nakabonne commented 3 years ago

@name-schema Thanks for your contribution! Let me just make one thing clear, just in case. Your commit and your Github account don't seem to be tied to each other:

image

I'd like to welcome you as a contributor, but as it stands, you don't count as a contributor. Would it be possible to authenticate the Github account on your local PC?

After that, feel free to force push.

keyslapperdev commented 3 years ago

I'm not too sure how to sync it. I've only used github casually and have never contributed to another's project before. I've made a change to local configs, lets see if it'll change when I make the updates to the code.