Pooling - Githubissues

nakagami / firebirdsql

Firebird RDBMS sql driver for Go (golang)

MIT License

224 stars 60 forks source link

Pooling #101

Closed NilsKrause closed 4 years ago

NilsKrause commented 4 years ago

Implement requirements for the database/sql pooling functionality.
Driver now reconnects automaticly when the database is ready again.
Returning concrete errors from wireprotocol for better error handling.

NilsKrause commented 4 years ago

Test failed because the number of function return arguments on parseDSN changed. DSN is now parsed into firebirdDsn type to comply with the database/sql.Connector interface. https://golang.org/pkg/database/sql/driver/#Connector

Gonna change the tests tomorrow. And add the commit to the PR.

NilsKrause commented 4 years ago

Okay, should be running smoothly now.

nakagami commented 4 years ago

Thanks, it seems very good to me.

But I hope someone's review. Or vote.

NilsKrause commented 4 years ago

Oh and also this should fix issue #29

nakagami commented 4 years ago

Umm, It seems very good to me! Thanks, Nils.