Closed xhit closed 3 years ago
thanks! I could probably fix it.
I've added a simple test, but I'm not sure if it's good enough yet. I'll see how it goes for a while longer.
Well, your implementation returns incorrect value for really big numbers like 99999999999999999999999999 and the max int128 170141183460469231731687303715884105727
Maybe I can fix that.
I think it's OK to get each 8 bytes at a time and add them up, but the result is definitely wrong. Thanks, I'll merge the pull request.
If there's a better way, I'll fix it later.
Example code: