nakagami / firebirdsql

Firebird RDBMS sql driver for Go (golang)
MIT License
227 stars 60 forks source link

go-critic check output #135

Open dshumko opened 2 years ago

dshumko commented 2 years ago

Result of source code check by go-critick

./consts.go:198:2: commentFormatting: put a space between // and comment text ./consts.go:441:1: commentFormatting: put a space between // and comment text ./decfloat.go:132:3: dupBranchBody: both branches in if statement has same body ./decfloat.go:206:3: dupBranchBody: both branches in if statement has same body ./decfloat.go:57:2: ifElseChain: rewrite if-else to switch statement ./decfloat.go:130:2: ifElseChain: rewrite if-else to switch statement ./decfloat.go:205:2: ifElseChain: rewrite if-else to switch statement ./dsn.go:48:2: commentFormatting: put a space between // and comment text ./event.go:19:1: commentFormatting: put a space between // and comment text ./event.go:90:9: unslice: could simplify e.subscribers[:] to e.subscribers ./eventmanager.go:40:25: commentFormatting: put a space between // and comment text ./eventmanager.go:44:25: commentFormatting: put a space between // and comment text ./srp.go:183:2: ifElseChain: rewrite if-else to switch statement ./wireprotocol.go:44:2: commentFormatting: put a space between // and comment text ./wireprotocol.go:729:4: commentFormatting: put a space between // and comment text ./wireprotocol.go:1341:2: commentFormatting: put a space between // and comment text ./wireprotocol.go:486:9: elseif: can replace 'else {if cond {}}' with 'else if cond {}' ./wireprotocol.go:224:2: ifElseChain: rewrite if-else to switch statement ./wireprotocol.go:420:4: ifElseChain: rewrite if-else to switch statement ./wireprotocol.go:578:3: ifElseChain: rewrite if-else to switch statement ./xsqlvar.go:260:2: assignOp: replace m = m % 60 with m %= 60 ./xsqlvar.go:261:2: assignOp: replace s = s % 60 with s %= 60 ./xsqlvar.go:323:3: ifElseChain: rewrite if-else to switch statement ./xsqlvar.go:332:3: ifElseChain: rewrite if-else to switch statement ./xsqlvar.go:341:3: ifElseChain: rewrite if-else to switch statement ./driver_test.go:58:3: assignOp: replace retorno = retorno + "/" with retorno += "/" ./driver_test.go:61:2: assignOp: replace retorno = retorno + TempFileName(file) with retorno += TempFileName(file) ./driver_test.go:599:2: commentFormatting: put a space between // and comment text ./driver_test.go:605:2: commentFormatting: put a space between // and comment text ./driver_test.go:612:2: commentFormatting: put a space between // and comment text ./driver_test.go:748:2: commentFormatting: put a space between // and comment text