nakagami / firebirdsql

Firebird RDBMS sql driver for Go (golang)
MIT License
220 stars 60 forks source link

Firebird services support #145

Open artyom-smirnov opened 1 year ago

artyom-smirnov commented 1 year ago

Low level services wire protocol implementation and wrappers for backup, nbackup, user and trace management

artyom-smirnov commented 1 year ago

This is WIP pull request. Before making it "ready to merge" I want to add maintenance management (repair, sweep, etc) and add some testing. If you have a some time, take a glance. May be you see it somehow different.

bat22 commented 1 year ago

In my opinion:

ps what does XPB mean?

artyom-smirnov commented 1 year ago

what does XPB mean?

Just common name for DPB, RPB.

bat22 commented 1 year ago

I think most likely case for XPBReader.Reset is reset with new byte slice for example: https://pkg.go.dev/strings#Reader.Reset, https://pkg.go.dev/bytes#Reader.Reset

nakagami commented 1 year ago

Great work!

I don't know much about the service API, but I think the code is good. Test code is also good.

It would be even better if you could include an example in the README if possible, but I think I will merge it without the README when this work is completed.