search

nakagami / pyfirebirdsql

Python DBAPI module for FirebirdSQL
BSD 2-Clause "Simplified" License
71 stars 29 forks source link

fix - pypy 7.3 encoding() fails for bytes - check for unicode under pypy #81

Closed dand-oss closed 4 years ago

dand-oss commented 4 years ago

python --version Python 3.7.4 (87875bf2dfd8, Sep 24 2020, 07:26:36) [PyPy 7.3.2-alpha0 with GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]

using example script from README

python ./test_firebirdsql.py Traceback (most recent call last): File "./test_firebirdsql.py", line 8, in password='xxx' File "/opt/pypy/site-packages/firebirdsql/init.py", line 96, in connect conn = Connection(**kwargs) File "/opt/pypy/site-packages/firebirdsql/fbcore.py", line 630, in init self._op_attach() File "/opt/pypy/site-packages/firebirdsql/wireprotocol.py", line 663, in _op_attach enc_pass = self.str_to_bytes(enc_pass) File "/opt/pypy/site-packages/firebirdsql/wireprotocol.py", line 236, in str_to_bytes return s.encode(charset_map.get(self.charset, self.charset)) AttributeError: 'bytes' object has no attribute 'encode'

mariuz commented 4 years ago

Maybe we should test higher pypy versions in travis

https://docs.travis-ci.com/user/languages/python/#pypy-support and related https://travis-ci.community/t/add-pypy-7-support/2228/6

I have added a pull request https://github.com/nakagami/pyfirebirdsql/pull/83