search

nakatamaho / mplapack

The MPLAPACK: multiple precision version of BLAS and LAPACK
Other
80 stars 11 forks source link

scl command does not work in Dockerfile_CentOS7_amd64 #63

Closed MacroUniverse closed 1 year ago

MacroUniverse commented 2 years ago

Hello, in Dockerfile_CentOS7_amd64 line 7 scl command has no effect since it only works on the current RUN command. To properly do this, I think you should use SHELL [ "scl", "enable", "devtoolset-9" ] instead. That will set the proper shell for every RUN command after.

MacroUniverse commented 1 year ago

You can verify this by adding RUN g++ --version after line 7 that it's not using version 9, but the default version of Centos7.9.2009.

nakatamaho commented 1 year ago

Thanks for your effort! And how about making a git pull request? It is really beneficial for me.

MacroUniverse commented 1 year ago

Done, please review.

nakatamaho commented 1 year ago

Thank you very much MacroUniverse! https://github.com/nakatamaho/mplapack/pull/65 closing