search

nakijun / morisoliver

Automatically exported from code.google.com/p/morisoliver
0 stars 0 forks source link

Add a clear button to the Filter Builder #161

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
It's good that the Filter Builder retains the previous filter definition, 
because the user can close the window to see underneath and then open again to 
review their definition.  Also, if they want to tweak their definition they can 
do so.  However, if they really want to start over by changing most of the 
info, they have to touch each bit.  A "clear all" button somewhere on the 
Filter Builder dialog (next to Cancel and Apply?) would be nice.

Original issue reported on code.google.com by Aleda.Fr...@state.ma.us on 27 Jun 2012 at 6:02

GoogleCodeExporter commented 9 years ago 
r383 addresses this

Right now the reset button only reset the values.  The user will still have to 
Apply the changes.  If this is not the desired behavior let me know.

Original comment by cpl...@gmail.com on 26 Oct 2012 at 8:02

GoogleCodeExporter commented 9 years ago 
Hi Charlton, I don't understand your comment above and I don't see any 
difference with the 
UI...http://maps.massgis.state.ma.us/map_ol_nov_2012/dor_la3.php  I click the 
Filter Builder - I expected another button on there that said "Clear" or 
"Reset".  Am I looking in the wrong place?

Original comment by Aleda.Fr...@state.ma.us on 31 Oct 2012 at 4:30

GoogleCodeExporter commented 9 years ago 
You'll need to change the toolConfig*filter.js that belongs to each deployment. 
 In r383 I changed toolConfig_sample_filter_prisons.js.

Original comment by cpl...@gmail.com on 31 Oct 2012 at 4:34

GoogleCodeExporter commented 9 years ago 
OK.  Boy, I'm going to have to update a lot of viewers.. I guess I have job 
security...

Original comment by Aleda.Fr...@state.ma.us on 31 Oct 2012 at 4:35

GoogleCodeExporter commented 9 years ago 
I think we should move all this config business from its current mix of control 
PHP + toolConfig .js's into ONE control file per deployment.  Feature request!

Original comment by cpl...@gmail.com on 31 Oct 2012 at 4:38

GoogleCodeExporter commented 9 years ago

Original comment by Aleda.Fr...@state.ma.us on 31 Oct 2012 at 4:42

GoogleCodeExporter commented 9 years ago

Original comment by Aleda.Fr...@state.ma.us on 31 Oct 2012 at 5:29

GoogleCodeExporter commented 9 years ago 
r391 fixes a bug that was keeping all the text boxes from being cleared.

I only changed this in toolConfig_sample_filter_prisons.js.  FYI the only line 
that changed was near the first occurrence of 'win.resetItems.push('.  It's the 
'id' line.

                  win.resetItems.push({
                     id  : el.id
                    ,typ : 'number'
                    ,val : el.getValue()
                  });

Original comment by cpl...@gmail.com on 31 Oct 2012 at 6:21

GoogleCodeExporter commented 9 years ago

Original comment by Aleda.Fr...@state.ma.us on 31 Oct 2012 at 6:28

GoogleCodeExporter commented 9 years ago 
I found a bug - Reset will clear everything if the window has remained open 
since the query, but if it has been closed and reopened it won't clear.

Example - 
http://maps.massgis.state.ma.us/map_ol_nov_2012/dor_la3.php?lyrs=Massachusetts%2
0Towns%20Survey%20Boundaries~massgis:GISDATA.TOWNSSURVEY_ARC~GISDATA.TOWNSSURVEY
_ARC::Default|Real%20Property%20Verified%20Market%20Sales~massgis:GISDATA.DOR_LA
3_PT~GISDATA.DOR_LA3_PT::Default&bbox=-71.07149939825234,42.43532451702461,-71.0
6283586313619,42.43871741865705&coordUnit=m&measureUnit=m&base=googleRoadmap¢er
=-7911160.9127691,5226669.539116&zoom=18&opacity=1,1&baseO=1&filt=undefined|%3Co
gc%3AFilter%20xmlns%3Aogc%3D%22http%3A//www.opengis.net/ogc%22%3E%3Cogc%3AAnd%3E
%3Cogc%3AIntersects%3E%3Cogc%3APropertyName%3ESHAPE%3C/ogc%3APropertyName%3E%3Cg
ml%3APolygon%20xmlns%3Agml%3D%22http%3A//www.opengis.net/gml%22%20srsName%3D%22E
PSG%3A900913%22%3E%3Cgml%3Aexterior%3E%3Cgml%3ALinearRing%3E%3Cgml%3AposList%3E-
7911643.1229279%205226413.6542206%20-7910678.7026103%205226413.6542206%20-791067
8.7026103%205226925.4240114%20-7911643.1229279%205226925.4240114%20-7911643.1229
279%205226413.6542206%3C/gml%3AposList%3E%3C/gml%3ALinearRing%3E%3C/gml%3Aexteri
or%3E%3C/gml%3APolygon%3E%3C/ogc%3AIntersects%3E%3Cogc%3APropertyIsBetween%3E%3C
ogc%3APropertyName%3ESALE_PRICE%3C/ogc%3APropertyName%3E%3Cogc%3ALowerBoundary%3
E%3Cogc%3ALiteral%3E300000%3C/ogc%3ALiteral%3E%3C/ogc%3ALowerBoundary%3E%3Cogc%3
AUpperBoundary%3E%3Cogc%3ALiteral%3E400000%3C/ogc%3ALiteral%3E%3C/ogc%3AUpperBou
ndary%3E%3C/ogc%3APropertyIsBetween%3E%3C/ogc%3AAnd%3E%3C/ogc%3AFilter%3E

Click Filter Builder tool.
Search for Property Type 101 and price between 200000 and 400000.
10 features will return.
If you click Reset now, the 101 and the price will clear.

However, if you were to do the above, get the 10 features, then close the 
Filter Builder dialog and then open it again with the Filter tool and THEN try 
to reset - the values won't clear.

Original comment by Aleda.Fr...@state.ma.us on 23 Nov 2012 at 8:06

GoogleCodeExporter commented 9 years ago 
r407 hopefully fixes this.  These changes will need to be applied to all 
filters that you may already have made.  :(

Original comment by cpl...@gmail.com on 23 Nov 2012 at 9:42

GoogleCodeExporter commented 9 years ago

Original comment by Aleda.Fr...@state.ma.us on 23 Nov 2012 at 10:06