Icons for GeoServer shapefile datastore inconsistent

In early summer 2012 I modified map.js to incorporate drawing and querying a 
shapefile GeoServer data store.  The folderset XML 
http://maps.massgis.state.ma.us/temp/oliver_folderset.xml had a type added 
"shp" and map.js was changed to detect "shp" and set the geometry type to 
"the_geom" instead of "SHAPE" for those layers.  That change involved maybe 4 
lines changed in map.js. (There's really only one layer - 
massgis:l3_taxpar_poly_assess which queried much faster as a shapefile data 
source than as an SDE data source of massgis:GISDATA.L3_TAXPAR_POLY_ASSESS).  

However, I was not able to modify the code to assign the correct datalayer 
icons. 

What we really need is types "shp_pt", "shp_line" and "shp_poly" in the folders 
which behave just like "pt", "line" and "poly" for all behavior - in/out of 
scale (yellow "!"), available/not available (red "!") or just fine (the 
shapes).  Also, the places in map.js where I set the_geom for "shp" would need 
to be updated to look for "shp_pt", "shp_line" or "shp_poly". 

On staging maps I tried to play with the ico2img function but I couldn't get it 
to work.  I'm also not familiar with the code for scale dependency and the 
yellow "!" and red "!".  So I think I should give up and let the experts handle 
it! :)

Original issue reported on code.google.com by Aleda.Fr...@state.ma.us on 23 Oct 2012 at 2:58

nakijun / morisoliver

Icons for GeoServer shapefile datastore inconsistent #177