nakijun / morisoliver

Automatically exported from code.google.com/p/morisoliver
0 stars 0 forks source link

Resolve “puzzle pieces” issue with some basemap layers in IE10 #209

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Recently a new issue has arisen where after some usage of OLIVER, including 
changing basemaps, base-layer tilesets get “scrambled”.  The following 
screenshot documents the issue.

The result of this enhancement will be a fix to OLIVER to eliminate this 
behavior.

Original issue reported on code.google.com by Aleda.Fr...@state.ma.us on 22 Apr 2013 at 1:07

Attachments:

GoogleCodeExporter commented 9 years ago
This corresponds to Task Order 5 enhancement 7

Original comment by Aleda.Fr...@state.ma.us on 22 Apr 2013 at 1:07

GoogleCodeExporter commented 9 years ago
See commit comments for r446.

Original comment by cpl...@gmail.com on 22 Apr 2013 at 1:48

GoogleCodeExporter commented 9 years ago
The problem seems to be gone with map_ol_to5/oliver.php I going to ask the 
person who reported it to try as well before I mark it verified.

Original comment by Aleda.Fr...@state.ma.us on 22 Apr 2013 at 8:35

GoogleCodeExporter commented 9 years ago
Note - this is how I made it happen in the first place:

I can reproduce it like this: (it can take a bit of panning, zooming and 
swtiching basemaps to get it actually, but you will every time) 

launch IE10
Remove all active datalayers to simplify things (but it doesn't matter one way 
or another) 
Switch to CloudMade
Pan
Switch to Bing Roads
Pan 
Switch to CloudMade
Pan
Switch to Bing Roads
etc. 

Or zoom instead of pan, eventually you'll see... 

Original comment by Aleda.Fr...@state.ma.us on 22 Apr 2013 at 8:36

GoogleCodeExporter commented 9 years ago
User can't reproduce the problem either so I'll mark it as verified.

Original comment by Aleda.Fr...@state.ma.us on 23 Apr 2013 at 1:27

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
On 4/25 we tried a different tactic, since upgrading to OpenLayers 2.13 caused 
3 side effects.  Charlton wrote made a modified OpenLayers 2.12 called 
OpenLayers-2.12-rc7-ie10-fix.js so we can fix the IE10 scrambled tiles but 
avoid the OpenLayers 2.13 side effects.  This does fix the IE10 scrambled tiles 
and avoids the "weird-fuzzy-zooming" side effect (Issue 210) and allow pan to 
continue on it's own (Issue 212).  Still can't zoom in to last level (Issue 
211) but I think this solution is the best so maybe we'll just have to live 
with that.

Original comment by Aleda.Fr...@state.ma.us on 25 Apr 2013 at 2:20

GoogleCodeExporter commented 9 years ago
Note, when I tested this in IE10 I made sure to go back to the default where 
"Disable script debugging (Internet Explorer)" is checked. (otherwise the error 
won't happen)

Original comment by Aleda.Fr...@state.ma.us on 25 Apr 2013 at 2:21

GoogleCodeExporter commented 9 years ago
I have been doing some heavy testing of OLIVER with 
OpenLayers-2.12-rc7-ie10-fix.js 
This are good but - when I click the print button in FF 20 nothing happens.
- Open OLIVER
- Click Print (nothing happens)

Print doesn't work in IE 10 either.
FF and IE 10 debuggers says basically the same thing:

SCRIPT5007: Unable to get property 'bounds' of undefined or null reference 
map.js, line 4726 character 11

Original comment by Aleda.Fr...@state.ma.us on 25 Apr 2013 at 4:39

GoogleCodeExporter commented 9 years ago
Print also doesn't work in Chrome Version 26.0.1410.64 m

Original comment by Aleda.Fr...@state.ma.us on 25 Apr 2013 at 5:01

GoogleCodeExporter commented 9 years ago
Well, that doesn't sound good.  The manual changes I made were in the areas 
where tiles talked to the map, and it was thanks to another project I work on.  
There is a chance that it broke something here.  I've exhausted the time 
allotted to this bug by trying to also squash the other OL 2.13 issues.  Maybe 
it's time to regroup.

Original comment by cpl...@gmail.com on 25 Apr 2013 at 6:05

GoogleCodeExporter commented 9 years ago
Give r454 a shot.

Original comment by cpl...@gmail.com on 26 Apr 2013 at 12:40

GoogleCodeExporter commented 9 years ago
Still no printing and getting stuck at the same line (see attachment).

Original comment by Aleda.Fr...@state.ma.us on 26 Apr 2013 at 2:44

Attachments:

GoogleCodeExporter commented 9 years ago
That line shouldn't read like that if you brought over a new map.js.php (and 
refreshed, perhaps).

if (tile && tile.bounds) {
...

Original comment by cpl...@gmail.com on 26 Apr 2013 at 3:03

GoogleCodeExporter commented 9 years ago
I think line 4796 still says that.
Maybe you changed 4755?
I cleared my cache, closed and opened FF, I see in FF the tile && tile.bound 
but only for 4755.

Original comment by Aleda.Fr...@state.ma.us on 26 Apr 2013 at 3:36

GoogleCodeExporter commented 9 years ago
Maybe the 2nd time will be the charm.

r455

Original comment by cpl...@gmail.com on 26 Apr 2013 at 5:17

GoogleCodeExporter commented 9 years ago
Yes, that fixed it.  Print now works in Firefox.  I'll go check in IE, Chrome 
and Safari.

Original comment by Aleda.Fr...@state.ma.us on 26 Apr 2013 at 5:37

GoogleCodeExporter commented 9 years ago
Works great in all 4 browsers

Original comment by Aleda.Fr...@state.ma.us on 26 Apr 2013 at 5:49