nalepae / pandarallel

A simple and efficient tool to parallelize Pandas operations on all available CPUs
https://nalepae.github.io/pandarallel
BSD 3-Clause "New" or "Revised" License
3.65k stars 210 forks source link

Add option to show single progress bar for all workers #239

Open lpuglia opened 1 year ago

lpuglia commented 1 year ago

Not sure why ApolloBian didn't reply further to the PR(https://github.com/nalepae/pandarallel/pull/203) but i'm here to make sure this change is merged.

codecov[bot] commented 1 year ago

Codecov Report

Merging #239 (545ac80) into master (46fc0e5) will decrease coverage by 0.83%. The diff coverage is 64.70%.

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   91.37%   90.55%   -0.83%     
==========================================
  Files          12       12              
  Lines         580      593      +13     
==========================================
+ Hits          530      537       +7     
- Misses         50       56       +6     
Impacted Files Coverage Δ
pandarallel/progress_bars.py 72.93% <53.84%> (-2.48%) :arrow_down:
pandarallel/core.py 91.09% <100.00%> (+0.09%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

till-m commented 1 year ago

Hi @lpuglia, thanks for taking care of this. Could you also make sure this change is covered by adding a fixture for the single bar option (see e.g. this)?

lpuglia commented 1 year ago

@till-m should I add tests for codecov?

till-m commented 1 year ago

The uncovered lines seem to only relate to the use in notebooks, I don't know any convenient way to test them. If you have something, feel free to let me know. I will try to test them manually by tomorrow so that I can merge this with no further delay.

lpuglia commented 1 year ago

@till-m done.

By the way, it looks fine in both ipywidget image and text mode: image

till-m commented 1 year ago

Hi @lpuglia,

thanks for changing the function argument name. Could you also add a small line in the documentation, specifically here updating the function parameter description?

singhsidhukuldeep commented 1 month ago

This is feature is so important that this PR almost brought a tear in my eyes Please merge this friends @lpuglia @till-m @ApolloBian @synapticarbors @bra-fsn @nalepae