Strict Concurrency (alternative)

nalexn / ViewInspector

Runtime introspection and unit testing of SwiftUI views

MIT License

2.09k stars 145 forks source link

Strict Concurrency (alternative) #302

Closed nalexn closed 2 weeks ago

nalexn commented 1 month ago

This is a follow-up PR for #291 that possibly replaces #298 and addresses the concerns from this comment.

Uses minimum @MainActor attributes in the public API, making it better compatible with the existing pre-concurrency test suits
Addresses all errors and most of the warnings for "Strict concurrency checking -> Complete" mode.

@Tyler-Keith-Thompson I cannot assign the review to you, but I hope you'll get a chance to look at this. Everyone else is welcome to review as well

Tyler-Keith-Thompson commented 1 month ago

@Tyler-Keith-Thompson I cannot assign the review to you, but I hope you'll get a chance to look at this. Everyone else is welcome to review as well

You bet! I'll try and take a look within the next week or so. A cursory glance tells me I think I like this direction better than where I was headed. However, I want to get it inside Xcode to see what's up and maybe even try it with the latest Swift 6 dev snapshot for kicks.

nalexn commented 1 month ago

@rafael-assis @bachand could you run this version on your test suit to see if the performance is affected? And also to evaluate if the new syntax causes any warnings / requires tests migration

bachand commented 1 month ago

@rafael-assis @bachand could you run this version on your test suit to see if the performance is affected? And also to evaluate if the new syntax causes any warnings / requires tests migration

Hey @nalexn, sorry for not responding sooner. Yes, we will try this next week and report back. Thank you for thinking of us!

rafael-assis commented 1 week ago

@rafael-assis @bachand could you run this version on your test suit to see if the performance is affected? And also to evaluate if the new syntax causes any warnings / requires tests migration

Hi @nalexn,

I apologize for the long delay in responding here.

I wanted to report that @bachand and I have run all of our test suites against the latest commit of the repo (e8b5facbc3759874323090084f3c4aaade933f9b) and everything went smoothly. We didn't observe any performance degradation or warnings. 💯

We appreciate you letting us know about the change that could impact our environment that consumes ViewInspector.

Thank you so much! 🙏