search

nalgeon / sqlean

The ultimate set of SQLite extensions
MIT License
3.76k stars 120 forks source link

Support musl builds? #127

Closed otoolep closed 3 months ago

otoolep commented 3 months ago

This is a PR just to communicate what I have in mind. Feel free to close.

Have you considered also adding musl builds to your releases? I tried these Makefile changes out (I have the musl-gcc compiler installed), and they worked great.

Why do this?

It would mean you would have a release ready for use inside alpine images, which are very popular as small-footprint Docker images. rqlite uses alpine for its Docker images, for example.

otoolep commented 3 months ago

With this build I'm able to then load sqlean into the version of rqlite which is built by musl (and which is used when creating rqlite Docker).

devnoname120 commented 3 months ago

Relevant: https://github.com/advplyr/audiobookshelf/pull/3236

nalgeon commented 3 months ago

I think musl builds are a great idea and I will try to incorporate them into the overall build pipeline. Thank you!

otoolep commented 3 months ago

Thanks.

You can see what I did here -- for Docker I made the download-sqlean-and-build process part of the image-creation itself, and it actually worked pretty well.

This now means that the Sqlean extensions are baked into the rqlite Docker image, and can be enabled simply by setting an Environment Variable. Pretty nice, if you ask me.

See https://rqlite.io/docs/guides/extensions/#docker

nalgeon commented 3 months ago

Sure, it's a great self-contained approach. And you don't have to rely on Sqlean builds.