nalgeon / sqlean

The ultimate set of SQLite extensions
MIT License
3.75k stars 120 forks source link

JSON1 #30

Closed CompuRoot closed 2 years ago

CompuRoot commented 2 years ago

Hello,

In the latest release 0.15.1, on the top you stated with message:

json1 extension in SQLite 3.37 is buggy, switched to 3.36.

I tried to find the case but failed, could you please point to the bug in JSON1 ?

nalgeon commented 2 years ago

Hey there! See this thread: https://sqlite.org/forum/info/858dee399ec0d982

CompuRoot commented 2 years ago

Ohh, I see, thank you.

Why then not to use Richard's suggestion to just compile with NDEBUG flag instead of missing recent changes in 3.37 branch ?

gcc -fPIC -shared -DNDEBUG json1.c -o json1.so
nalgeon commented 2 years ago

Because there are no functional changes to JSON1 in 3.37.

CompuRoot commented 2 years ago

Im lost, sorry, why then state that "json1 extension in SQLite 3.37 is buggy, switched to 3.36" if "there are no functional changes to JSON1 in 3.37".

nalgeon commented 2 years ago

3.37 brings no new features to JSON1, but breaks its functionality. Therefore, there is no profit in using 3.37.