search

nalimilan / FreqTables.jl

Frequency tables in Julia
Other
89 stars 19 forks source link

Update to Julia 1.0 #27

Closed bkamins closed 6 years ago

bkamins commented 6 years ago

@nalimilan I do not want to start pushing PRs migrating this package to Julia 1.0, before I understand your plans regarding this. Most of things that fail should be fixable by femtocleaner I guess (and NamedArrays on master are ready/almost ready for Julia 1.0).

Please let me know how you want to proceed and how I could help (I really like this package 😄).

nalimilan commented 6 years ago

Please feel free to go ahead and do anything necessary to get the tests to pass on 1.0. Hopefully Femtocleaner will do most of the work.

bkamins commented 6 years ago

Yes, but I guess it is you who should initiate Femtocleaner on the repo? Or I am missing something?

nalimilan commented 6 years ago

AFAICT it's enabled already?

bkamins commented 6 years ago

But I saw in DataFramesMeta.jl that Femtocleaner automatically created a PR. Do you know how to trigger this? Then I would review what would be left broken.

nalimilan commented 6 years ago

You just have to bump the minimum Julia version in REQUIRES and open a PR, and it should clean everything it can.

bkamins commented 6 years ago

OK. I will do it when NamedArrays are tagged with a new release.

nalimilan commented 6 years ago

See https://github.com/nalimilan/FreqTables.jl/pull/28 for a first step.