search

nalimilan / FreqTables.jl

Frequency tables in Julia
Other
88 stars 19 forks source link

Reexport Name from NamedArrays #31

Open bkamins opened 6 years ago

bkamins commented 6 years ago

I think we should reexport Name from NamedArrays in this package?

nalimilan commented 6 years ago

Tough question. In general I'd tend to reexport a full package rather than individual functions. NamedArrays is kind of special since you can use them a lot while only calling Base functions, but it's API is also small so reexporting everything wouldn't be too bad.

Finally, another consideration is that we could have the objective of including FreqTables and NamedArrays in Stats.jl, in which case it would make sense to keep FreqTables limited in the functionality it exports.

bkamins commented 6 years ago

We can keep it open now (I am OK with any decision you make - just wanted to highlight the issue). The problem, as probably you are aware, is that now you have to do using NamedArrays to index into an array using integers as names (which is pretty common) so it is not enormously bad (but inconvenient).