search

nalimilan / FreqTables.jl

Frequency tables in Julia
Other
89 stars 19 forks source link

Allow strings for column names #53

Closed nalimilan closed 4 years ago

nalimilan commented 4 years ago

Since these are allowed by DataFrames.

Fixes #51.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.06%) to 95.833% when pulling f975588b60538bba7895feb282256d5b252f34a8 on nl/string into ab7abf5ff0bf9a5a70933d401a9711fd83943c6b on master.

bkamins commented 4 years ago

Thank you! The only question is what happens when you do setdimnames! - are then they always converted to Symbol? (I guess yes, but I do not see such tests)

nalimilan commented 4 years ago

Good catch. The input type was preserved, but in case of mixed type better convert everything to a common type.

nalimilan commented 4 years ago

https://github.com/JuliaRegistries/General/pull/22847