Remove unnecessary prop(::NamedArray, ...) method

nalimilan / FreqTables.jl

Frequency tables in Julia

Other

90 stars 19 forks source link

Remove unnecessary prop(::NamedArray, ...) method #57

Closed nalimilan closed 3 years ago

nalimilan commented 3 years ago

@bkamins I guess it used to be needed but that doesn't seem to be the case anymore.

bkamins commented 3 years ago

Why is it unnecessary? Because the generic method will correctly handle this?

nalimilan commented 3 years ago

Yes, the result seems to be the same with only the generic code -- and tests pass. Probably that feature was added to NamedArrays at some point.

coveralls commented 3 years ago

Coverage decreased (-0.06%) to 95.775% when pulling ae74e7888392065d781c3b4c0ecbf9b866257f57 on nl/prop into 182af0972e302f19f80fe151d1ffae7b0f0618dd on master.