search

nalmadi / fix8

Fix8 (Fixate) is an Open-Source GUI Tool for Working with Eye Tracking Data in Reading Tasks.
Mozilla Public License 2.0
5 stars 0 forks source link

Keyboard control #69

Closed AgLyx3 closed 7 months ago

AgLyx3 commented 8 months ago

What? Add a keyboard control (J - left, L - right, I - up, K - down) to move the selected fixation.

Why? Allow the users to make more subtle changes to the selected fixation   How? Add four more key press events

Question I was wondering if I should add an error message if the user touches the key without selecting an existing fixation.

nalmadi commented 8 months ago

This looks really good, good job!

I think we have some overlapping fields like last_selected_fixation, maybe there's another field that does the same thing. It would be super helpful if you can refactor this and remove instances were we have multiple fields that describe the same thing. You can enhance the names too, some field names are not specific enough.

Is this PR ready for review, or do you want to add something to it?