Color jump on color select

namacha / python-magichue

Control Magic Hue(Magichome) in Python.

MIT License

60 stars 12 forks source link

Color jump on color select #13

Closed XilefTech closed 2 years ago

XilefTech commented 5 years ago

I don't really know if this is really a bug or just a feature, I like to have but when I select a color with light.rgb, the color doesn't jump immediately, but it just fades. I would wish me a function that changes the color instantaniously. I'm using the #7 fix branch.

Thanks Felix

namacha commented 5 years ago

After setting color, does it fade to black? or its color changed with fading effect?

Maybe protocol on my device differs to the one on your bulb. Which bulb do you use?

XilefTech commented 5 years ago

Thanks for the quick reply I'm using this controller and if I set a color, the stripes fade to that set color, but I want them to jump to that color. They don't fade to black or any other color (except the previously set one). with the main branch, the colorchange wouldn't work, but as I exxplained everything works with the #7 branch

namacha commented 5 years ago

Alright, I gonna buy the same bulb and work on update. Although I’ve been busy recently, so please be patient.

namacha commented 5 years ago

I did some tests with magichue led stripe, and found that behavior is in the specification. However, there seems to be a some hack to change color immediately. I will contain this hack in the future commit. Please wait for a while.

XilefTech commented 5 years ago

Okay thanks I'm not in a hurry but hope you can make it possible soon

namacha commented 4 years ago

Just committed updates. I haven't merged commit to master branch and written README, but you can try it with feat-#13 branch.

To disable fading on color change, run codes as below.

import magichue

l = magichue.Light('192.168.0.17')  # change address
l.allow_fading = False
l.rgb = (255, 0, 0)  # this should jump to red (but with a little delay).

I'd appreciate if you report a another bug or something.

tape

XilefTech commented 4 years ago

Thanks a lot! I'll try it out as soon as I can, but lately, I got very much to do with school :(

XilefTech commented 4 years ago

I just found time to test it, and it works!

But there is a small problem, that when I'm using light.allow_fading = False I get a slight flickering on my stripes, like if you would turn them of and back on for a few millis. which is verry annoying. without light.allow_fading = False I don't get any of these artifacts. I also noticed, that it takes a lot more time to change the colors than without.

XilefTech commented 4 years ago

Sorry, if I'm impatient, but since I didn't get any answer for more than a week, I wanted to ask, If someone is actually working on the problem or at least just looked at it....

namacha commented 4 years ago

I’m sorry for not responding sooner.
My bulb (same bulb as you I think) is working correctly, so I wonder if your network environment has problem. Or there is no problem on your network, I want you to do some tests with your bulb to try to find out the cause of problem. I will tell about tests later.

This is just a quick note, please excuse my brevity.