search

namaggarwal / splitwise

Python SDK for Splitwise
MIT License
183 stars 46 forks source link

Wrong parameter "friendship_id" for getExpenses #62

Closed quaqo closed 1 year ago

quaqo commented 2 years ago

According to API ref v.3.0 the correct parameter should be "friend_id", friendship_id is then returned for getExpense.

Patch below:

./splitwise/init.py

460c460
<                     friendship_id=None,
---
>                     friend_id=None,
471,472c471,472
<             group_id(long, optional): GroupID of the expenses
<             friendship_id(long, optional): FriendshipID of the expenses
---
>             group_id(long, optional): If provided, only expenses in that group will be returned, and friend_id will be ignored.
>             friend_id(long, optional): ID of another user. If provided, only expenses between the current and provided user will be returned.
namaggarwal commented 2 years ago

Thanks. Let me have a look

CloCkWeRX commented 2 years ago

image

namaggarwal commented 1 year ago

Fixed in v3.0.0.