search

namaggarwal / splitwise

Python SDK for Splitwise
MIT License
183 stars 46 forks source link

#62 Fix naming #69

Closed CloCkWeRX closed 1 year ago

CloCkWeRX commented 2 years ago

Fixes #62

https://dev.splitwise.com/#tag/expenses/paths/~1get_expenses/get is a bit silly, as the param is friend_id but the JSON response is friendship id

namaggarwal commented 1 year ago

Thanks, its a breaking change, I will accept this once I have created a new branch for next major version

CloCkWeRX commented 1 year ago

It might be less of a breaking change than feared; as the underlying API params are as per the new naming; so by extension, no one could have used this successfully previously. That said, semver ftw :)

namaggarwal commented 1 year ago

Fixed in master