search

naman03malhotra / auto-skip-for-netflix-and-prime

Netflix, Prime, JioCinema, Hotstar Skip Intros Automatically
http://bit.ly/aspn_pro
Other
49 stars 128 forks source link

Support multiple translation for each skip type. #30

Open naman03malhotra opened 3 years ago

naman03malhotra commented 3 years ago

As reported by many users, each skip type can have multiple translations in different languages.

https://github.com/naman03malhotra/auto-skip-for-netflix-and-prime/blob/master/src/utils/i18n.js

In file i18n.js we need to add support for an array of translated keywords instead of a single string.

naman03malhotra commented 3 years ago

As mentioned in the review, skip_intro has two translations. image

naman03malhotra commented 3 years ago

Modifications need to made to the existing design, for how we are creating element mapping.

DasKashi commented 3 years ago

Oh my ... submitted pull request #35 to change "Intro" to "Vorspann" since it's been bugging me while watching. Feel free to reject it ... didn't actually know that both were used.

naman03malhotra commented 3 years ago

Hey @DasKashi, for now I have merged the PR but we need to work on a permanent solution for this. Let me know if you have time, we can discuss, not closing this issue for now.

naman03malhotra commented 3 years ago

This PR https://github.com/naman03malhotra/auto-skip-for-netflix-and-prime/pull/35 will be effective form v3.3.4. I have submitted it for review, will take a day or so to publish.

DasKashi commented 3 years ago

I tried contacting you via Twitter (following you now) ... weirdly enough, it's not possible to send direct messages on github.

naman03malhotra commented 3 years ago

Thanks for the PR @DasKashi, v3.3.4 should be up by tomorrow. Still in review :(

I never tried to send a message on Github as well. I think raising pull requests or issues is a good way to interact with the developer.

Btw, we have a couple of issues listed, do give them a try.

Also if possible and you like the extension, you can leave feedback on the chrome web store that will help with the visibility of the extension.

naman03malhotra commented 3 years ago

@DasKashi v3.3.4 is live now.