search

namazso / OpenHashTab

📝 File hashing and checking shell extension
GNU General Public License v3.0
3.12k stars 119 forks source link

x64 Windows version #163

Closed Neustradamus closed 1 year ago

Neustradamus commented 1 year ago

Hi @namazso,

It is possible to create the x64 Windows version?

Currently it is in x86 only.

Thanks in advance.

namazso commented 1 year ago

Currently it is in x86 only.

No it isn't. The installer will install the correct version. The fact that it works at all shows it's the right architecture, as only matching architecture can work as a shell extension.

Neustradamus commented 1 year ago

@namazso: I have tested on a Windows x64 machine, it has been installed in "C:\Program Files (x86)\OpenHashTab\"

namazso commented 1 year ago

Oh the install location can very well be incorrect, but don't worry about that, just that it installs a 64 bit version correctly, which you can see as it installed the x64 dlls. You can also check the OpenHashTab.dll with any PE viewer to see it's also 64 bit.

Neustradamus commented 1 year ago

@namazso: Can you solve this installer issue?

namazso commented 1 year ago

Might look at it but it might just be a limitation of InnoSetup because it sees I have both 32 and 64 bit dlls in the same installer. However, considering it doesn't affect the operation of the program at all, I don't feel like this is too important.

Btw you can simply change the install location in the installer:

image

Neustradamus commented 1 year ago

@namazso: Have you found the problem?

namazso commented 1 year ago

@Neustradamus This was fixed with https://github.com/namazso/OpenHashTab/commit/3abe557c2248c5602639c746906d5e6b05bb2e75 as part of removing 32-bit support entirely