Hey could you revamp this please it's kindof messy imo

[eue398]

revamp // recode

[wthueb]

it's relatively clean honestly. just because it doesn't fit your coding style doesn't mean it's wrong lmao On Thu, Oct 12, 2017 at 8:51 AM uwu notifications@github.com wrote:

//

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/namazso/nSkinz/issues/19, or mute the thread https://github.com/notifications/unsubscribe-auth/AWFvKYzOrg9nGQGUpYXnGgU1whlOEqbgks5srgtOgaJpZM4P29Ly .

[eue398]

butt me seen the coder say its messy

[namazso]

well, there are certain issues i know of but cba to clean up. one is the possible race condition with the configs, which should be pretty obvious to anyone reading the source. The other is the slowness of updating the vector index from the skin id. These require two special containers (preferably a static memory backed lockfree concurrent vector, and a multi-indexed map). imo implementing these, or pulling in a boost dependency which has these both would be kinda overkill for a project of this size, so i just leave these in, since they rarely cause problems.

[ghost]

It's not that messy I don't like how @namazso put all of their hooks in separate files instead of a manager and a bunch of utility files being separate.

[wthueb]

that's just personal preference. i like it that way tbh On Thu, Oct 26, 2017 at 3:21 AM terryadavis notifications@github.com wrote:

It's not that messy I don't like how @namazso https://github.com/namazso put all of their hooks in separate files instead of a manager and a bunch of utility files being separate.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/namazso/nSkinz/issues/19#issuecomment-339575272, or mute the thread https://github.com/notifications/unsubscribe-auth/AWFvKSXX9SX9vrDMqnLM3IrO66j2KBiLks5swDLwgaJpZM4P29Ly .

[noxipoop]

hey for some reason it keeps giving me 11 errors then it gives me 37 errors and i cant compile it :( im using visual studio 2017 and is there a way to keep it undetected forever such as adding junk code?

[namazso]

@terryadavis you dont even need to do any of that in fact. The paths are configured to be relative by default, and since imgui and json are submodules they get automatically cloned with --recursive. The project compiles freshly out of the box on Visual Studio 2017 + DirectX SDK

@noxipoop please open a new issue and do not clutter other issues in the future, thanks.