namebasehq / api-documentation

Public documentation for the Namebase exchange and marketplace API.
https://namebase.io
67 stars 12 forks source link

Add API client in Go #3

Closed sniperem closed 4 years ago

sniperem commented 4 years ago

Really appreciate this handshake project, hope it would be popular in the future. And it's a great pity that I'm not qualified for the Airdrop! So I wrote a golang API to trade on this namebase exchange. BTW, this exchange is awesome.

turbomaze commented 4 years ago

This is great!! Thanks so much for making a Go client.

Putting a client on this page connotes some level of "official approval", and exchange clients are sensitive pieces of software since they can trivially steal user API keys.

I have not yet reviewed the Go code for your attached repository (will do soon!), but before then, would you mind messaging me (@igliu) on our Namebase discord https://discord.gg/5Ju8Ss5 just so you're not an anonymous internet face? Haha. Can reach out on our #support channel. Don't need to publicly reveal who you are (just to me), but I would feel more comfortable listing this client on our docs if I have a real-life identity to interact with.

Cheers

sniperem commented 4 years ago

It's a long time since my PR, you may forgot to review my API client in Go? It's ok to reject if the code doesn't meet your expectation:) just hope it's useful for someone like me to trade on Namebase Pro(I've run a market maker algo for a month with this client)

turbomaze commented 4 years ago

Ahh I am so sorry for the delay. Other things came up as you can imagine and this fell under the radar. If I don't reply to this properly and leave comments / merge it within 48 hours I'll immediately send you 100 HNS personally haha

sniperem commented 4 years ago

haha, take your time~