Open stas-nc opened 4 days ago
Took flame chart during a load test to the local ILC server connected to the production registry (see attached file) in the jira ticket.
It showed a few hot functions, one of the most important is CacheWrapper.getCache()
, which under the hood makes JSON.parse on each call (because storage internally uses local storage polyfill).
I have rewritten that part to use a pure in-memory cache on the server side and native local storage on the client side.
There are also a few more hot functions that will be handled in tailor lib and maybe here in separate PRs.
Commit SHA:465669aabbe64bba827c648a3e9af30f54554b85
Code coverage diff between base branch:master and head branch: perf/fix-cpu-perf
Commit SHA:465669aabbe64bba827c648a3e9af30f54554b85
Code coverage diff between base branch:master and head branch: perf/fix-cpu-perf
Commit SHA:465669aabbe64bba827c648a3e9af30f54554b85
Code coverage diff between base branch:master and head branch: perf/fix-cpu-perf
I've briefly reviewed this PR while it was in draft. Could u please elaborate on the reason of leakage?