Closed aerth closed 4 years ago
Triggering a Travis build...
@aerth Can you bump the pflag
module dependency to 45c278ab3607870051a2ea9040bb85fcb8557481
? (The maintainer of pflag
hasn't tagged a release in a long time, and there are some fixes in master branch that aren't in a release.)
@aerth It looks like you're replacing the Linux Travis job with a Windows Travis job. Can you add a 2nd job instead of replacing the existing one? The existing Linux job is useful, specifically the static analysis and cross-compiling checks. (It may need minor tweaks since we've split off certinject to its own repo, but they should be straightforward.)
ACK 173e4feaadbc4aaf9dc6b9ab911abc034ac1fccd except for the aforementioned 2 issues.
@aerth There are a bunch of checks in .travis/script
that aren't currently being run by the Linux Travis job, in particular the gometalinter
check and the gox
check. That said, technically those were already broken by the repo split prior to this PR, so I'm not going to block this PR any further with those; we can address those in a subsequent PR.
utACK 26e91f42b9181fc03fe7333f3db3bb33163de32e
And test that injection is working properly on windows, and that using a config file works.