Remove confusing instructions to use "null HPKP" - Githubissues

namecoin / certinject

Inject certificates into Windows CryptoAPI trust store, with EKU and name constraints.

https://www.namecoin.org/

GNU General Public License v3.0

2 stars 5 forks source link

Remove confusing instructions to use "null HPKP" #74

Open JeremyRand opened 7 years ago

JeremyRand commented 7 years ago

https://github.com/namecoin/ncdns/blob/e16ad6f62ce63c7522469acd95e21228e0488dfb/certinject/certinject_windows.go#L17 instructs users to use "set up null HPKP". This is confusing since the NUMS public key hash we're using is no longer all 0's. "null HPKP" should be reworded to "NUMS HPKP". It might also be useful to mention tlsrestrict_chromium_tool in that help message.

[x] Reword "null HPKP" to "NUMS HPKP" for CryptoAPI.
[x] Reword "null HPKP" to "NUMS HPKP" for NSS.
[ ] Mention tlsrestrict_chromium_tool for CryptoAPI.
[ ] Mention tlsrestrict_chromium_tool for NSS.