search

namecoin / certinject

Inject certificates into Windows CryptoAPI trust store, with EKU and name constraints.
https://www.namecoin.org/
GNU General Public License v3.0
2 stars 6 forks source link

Update wincrypt.h #78

Closed JeremyRand closed 1 year ago

JeremyRand commented 2 years ago

We currently use wincrypt.h from ReactOS (LGPLv2.1+), which maxes out at Prop ID 84. ReactOS's copy of this file seems to be imported from Wine. MinGW-w64 has an alternate implementation (public domain) that has additional Prop ID's up to 127. It would be useful to send Wine an updated version of this header that implements the extra Prop ID's. Once ReactOS merges it, we can update certinject.

JeremyRand commented 2 years ago

Note that ReactOS participates in Hacktoberfest, though Wine does not appear to. However, AFAICT this issue is not eligible for Hacktoberfest because submitting someone else's code violates Hacktoberfest rules.

JeremyRand commented 2 years ago

On second thought, I think we'd be willing to accept a PR without going through Wine/ReactOS; just sending us the MinGW-w64 header will be fine. That should be fine for Hacktoberfest too.